fix: decode returns None with u64::MAX + 1
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
changed the title
None with u64::MAX + 1None with u64::MAX + 1
dermesser
reviewed
Mar 1, 2024
| if b & MSB == 0 || shift > (9 * 7) { | ||
| success = b & MSB == 0; | ||
| if shift > (9 * 7) { | ||
| // BUGIFX: this check is required to ensure that we actually return `None` when `src` has a value that would overflow `u64`. |
|
thank you for this PR! Would you mind cleaning up the commit history and squashing them into one? |
|
hi, any progress on merging this? Also, @dermesser -- you can simply "squash merge" (there is a dropdown next to the merge button) -- all my projects actually only allow squash-merging to keep the history clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
[0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x02]is the encoding ofu64::MAX.This does not return
Nonewhen decoding even though it should.This PR fixes this issue.
Changes
u64::decode_varnow returnsNonewhen a 10th byte is used but is more than1.